[FIXED] Subscribe timeout should send a close request #347
+63
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an application gets a timeout on a Subscribe() call, it does not know if the server is actually going to process the request. The request could have been just processed but the client timed-out before getting the response back, or there is a bit of a backlog of requests in the server and the request will be processed after the request times out in the client. If that happens, and if the application maintains its connection, then it is possible that the server processes the subscription and keep that subscription alive, although the application does not have an handle on this subscription (the Subscribe() call has failed). On timeout, the library will now send a request to close the subscription. However, the protocol normally requires the AckInbox which is assigned by the server and sent back as part of the subscription response protocol. The library will send the request with the subscription inbox. Newer servers (v0.21.0+) will be able to handle that, older will report that no subscription was found for the subscription close request. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an application gets a timeout on a Subscribe() call, it does not
know if the server is actually going to process the request. The request
could have been just processed but the client timed-out before getting
the response back, or there is a bit of a backlog of requests in the
server and the request will be processed after the request times out
in the client.
If that happens, and if the application maintains its connection, then
it is possible that the server processes the subscription and keep that
subscription alive, although the application does not have an handle
on this subscription (the Subscribe() call has failed).
On timeout, the library will now send a request to close the subscription.
However, the protocol normally requires the AckInbox which is assigned by
the server and sent back as part of the subscription response protocol.
The library will send the request with the subscription inbox. Newer
servers (v0.21.0+) will be able to handle that, older will report that no
subscription was found for the subscription close request.
Signed-off-by: Ivan Kozlovic ivan@synadia.com